This repository was archived by the owner on Oct 6, 2025. It is now read-only.
fix(standalone): don't copy config if Desktop is treated as Moby#146
Merged
doringeman merged 1 commit intomainfrom Aug 27, 2025
Merged
fix(standalone): don't copy config if Desktop is treated as Moby#146doringeman merged 1 commit intomainfrom
doringeman merged 1 commit intomainfrom
Conversation
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
xenoscopic
approved these changes
Aug 27, 2025
Contributor
xenoscopic
left a comment
There was a problem hiding this comment.
LGTM. If we get too many more _MODEL_RUNNER_TREAT_DESKTOP_AS_MOBY checks in the code, we might want to abstract it somewhere else into some sort of utility function, but I think this takes us to three checks and that's probably fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, we were copying the Docker config inside the
docker/model-runnercontainer running in Docker Desktop, and this made methods likepullfail due to the missingdocker-credential-desktop.Now everything works as expected: