This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Conversation
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
rm-multiple-models
branch
from
34f1638 to
eb08c54
Compare
ilopezluna
reviewed
Apr 8, 2025
Contributor
There was a problem hiding this comment.
Thank you very much @glours for helping here 🙏
I've tried the PR and everything works great, just added a suggestion to use ggcr because IMHO its going to make this and future changes more easy/readable. Let me know what you think!
| return "", fmt.Errorf("failed to unmarshal response body: %w", err) | ||
| } | ||
|
|
||
| for _, m := range modelsJson { |
Contributor
There was a problem hiding this comment.
WDYT about using Google Go Container Registry to parse the reference as we do here:
https://github.com/docker/model-distribution/blob/97a8b3d86792da03d537a3950e9a26b0704f63a0/pkg/store/index.go#L201 ?
doringeman
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to remove multiple model from the same command call
Could be useful to have the same capabilities as the main docker cli in the future
for example Docker CLI permits
docker rm $(docker ps --filter status=exited -q)we could have the same-qattribut todocker model listand dodocker model rm $(docker model list -q)to remove all the model at once