Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Comments

Add docker model logs#29

Merged
doringeman merged 2 commits intodocker:mainfrom
doringeman:logs
Apr 15, 2025
Merged

Add docker model logs#29
doringeman merged 2 commits intodocker:mainfrom
doringeman:logs

Conversation

@doringeman
Copy link
Collaborator

@doringeman doringeman commented Apr 15, 2025

docker model logs --help
Usage:  docker model logs [OPTIONS]

Fetch the Docker Model Runner logs

Options:
  -f, --follow       Follow log output
      --no-engines   Skip inference engines logs

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
func newLogsCmd() *cobra.Command {
var follow bool
c := &cobra.Command{
Use: "logs [OPTIONS]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really support options here? which ones?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  -f, --follow   Follow log output

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, do you mean it should be OPTION or mention follow directly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I was wondering because I didn't see any instruction of which options will be, so I was unsure of how the users would know which options are available

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker model logs --help

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 options now! 😁

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
@doringeman doringeman requested review from ilopezluna and p1-0tr April 15, 2025 14:12
@doringeman doringeman merged commit 4b2bc71 into docker:main Apr 15, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants