This repository was archived by the owner on Oct 6, 2025. It is now read-only.
run: Ensure model name/tag only if it's not pulled#37
Merged
doringeman merged 1 commit intodocker:mainfrom Apr 25, 2025
Merged
Conversation
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
p1-0tr
approved these changes
Apr 25, 2025
ilopezluna
approved these changes
Apr 25, 2025
kiview
approved these changes
Apr 25, 2025
Member
kiview
left a comment
There was a problem hiding this comment.
note: Eventually we should transition into a development pace, that submits such fixes together with their tests 😉
glours
approved these changes
Apr 25, 2025
| } | ||
| } | ||
| if model != modelDetail.Tags[0] { | ||
| } else if model != modelDetail.Tags[0] { |
Contributor
There was a problem hiding this comment.
I wonder if pullModel function should not return a Model struct, so you can update modelDetail 🤔
Anyway it can be done in a follow up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running a model which has to be pulled will result in a panic.
Without this patch: