This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Merged
Conversation
xenoscopic
reviewed
May 12, 2025
commands/root.go
Outdated
| newStatusCmd(desktopClient), | ||
| newPullCmd(desktopClient), | ||
| newPushCmd(desktopClient), | ||
| newPackagedCmd(desktopClient), |
Contributor
There was a problem hiding this comment.
You'll need to rebase on main where desktopClient is now a global in the commands package, but other than removing it from the newPackageCmd constructor, there shouldn't be any other changes.
Signed-off-by: Emily Casey <emily.casey@docker.com>
xenoscopic
approved these changes
May 12, 2025
commands/package.go
Outdated
| // Parse the reference | ||
| cmd.PrintErrln("Packaging model %q\n", tag) | ||
| target, err := registry.NewClient( | ||
| registry.WithUserAgent("model-cli"), |
Contributor
There was a problem hiding this comment.
nit: Maybe append the version?
Signed-off-by: Emily Casey <emily.casey@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
docker model packagecommand:Things to note:
--pushflag is required now. This is a bit awkward but allows us to default to local packaging when we add this in the future.--ggufis required and must point at a local file for now, but we will support building from other sources in the future