Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Comments

Add docker model package command#52

Merged
xenoscopic merged 2 commits intomainfrom
package
May 12, 2025
Merged

Add docker model package command#52
xenoscopic merged 2 commits intomainfrom
package

Conversation

@ekcasey
Copy link
Contributor

@ekcasey ekcasey commented May 12, 2025

Adds docker model package command:

Usage:  docker model package --gguf <path> [--license <path>...] --push TARGET

package a model

Options:
      --gguf string           absolute path to gguf file (required)
  -l, --license stringArray   absolute path to a license file
      --push                  push to registry (required)

Things to note:

  • --push flag is required now. This is a bit awkward but allows us to default to local packaging when we add this in the future.
  • --gguf is required and must point at a local file for now, but we will support building from other sources in the future

commands/root.go Outdated
newStatusCmd(desktopClient),
newPullCmd(desktopClient),
newPushCmd(desktopClient),
newPackagedCmd(desktopClient),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to rebase on main where desktopClient is now a global in the commands package, but other than removing it from the newPackageCmd constructor, there shouldn't be any other changes.

Signed-off-by: Emily Casey <emily.casey@docker.com>
// Parse the reference
cmd.PrintErrln("Packaging model %q\n", tag)
target, err := registry.NewClient(
registry.WithUserAgent("model-cli"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe append the version?

Signed-off-by: Emily Casey <emily.casey@docker.com>
@xenoscopic xenoscopic merged commit 4b42749 into main May 12, 2025
4 checks passed
@xenoscopic xenoscopic deleted the package branch May 12, 2025 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants