Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Comments

standalone: fix Compose hostname for CE/Cloud and implement logs for CE#55

Merged
xenoscopic merged 3 commits intomainfrom
standalone-refinement
May 13, 2025
Merged

standalone: fix Compose hostname for CE/Cloud and implement logs for CE#55
xenoscopic merged 3 commits intomainfrom
standalone-refinement

Conversation

@xenoscopic
Copy link
Contributor

This PR adds two small refinements for Docker CE usage:

  • It switches to using host.docker.internal as the injected hostname for Compose projects when using Docker CE or Docker Cloud; this is easier to inject into Compose projects as an additional host
  • It implements docker model logs for standalone container installs

Signed-off-by: Jacob Howard <jacob.howard@docker.com>
@xenoscopic xenoscopic requested a review from ekcasey May 13, 2025 17:16
@xenoscopic xenoscopic force-pushed the standalone-refinement branch 2 times, most recently from 8f7b642 to 32e3313 Compare May 13, 2025 17:18
Signed-off-by: Jacob Howard <jacob.howard@docker.com>
@xenoscopic xenoscopic force-pushed the standalone-refinement branch from 32e3313 to a6ad557 Compare May 13, 2025 17:19
@xenoscopic
Copy link
Contributor Author

One small detail: I couldn't add support for the --no-engines flags in the CE case because they get merged into the main logs.

Co-authored-by: Emily Casey <emily.casey@docker.com>
Copy link
Contributor

@ekcasey ekcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xenoscopic xenoscopic merged commit 4f4b6ab into main May 13, 2025
4 checks passed
@xenoscopic xenoscopic deleted the standalone-refinement branch May 13, 2025 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants