This repository was archived by the owner on Oct 6, 2025. It is now read-only.
cli: fix autocompletion to work with context detection#58
Merged
xenoscopic merged 1 commit intomainfrom May 14, 2025
Merged
Conversation
Signed-off-by: Jacob Howard <jacob.howard@docker.com>
doringeman
reviewed
May 14, 2025
| return nil, cobra.ShellCompDirectiveNoFileComp | ||
| } | ||
| models, err := desktopClient.List() | ||
| models, err := desktopClient().List() |
Collaborator
There was a problem hiding this comment.
Can't we just use desktopClient *desktop.Client if we're running cmd.Parent().PersistentPreRunE?
Contributor
Author
There was a problem hiding this comment.
I suppose we could, but it would create a circular dependency, and passing the value through at command construction captures the nil value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autocomplete didn't function after context detection because (1) it had a stale (
nil) client reference and (2) CLI initialization wasn't occurring on the autocomplete path.