This repository was archived by the owner on Sep 29, 2025. It is now read-only.
distribution client: return structured response for untagged and deleted models#107
Merged
doringeman merged 1 commit intodocker:mainfrom Jul 10, 2025
Merged
Conversation
ilopezluna
reviewed
Jul 10, 2025
| tagRef, err := name.NewTag(tag) | ||
| if err != nil { | ||
| return Index{} | ||
| return name.Tag{}, Index{} |
Contributor
There was a problem hiding this comment.
Oh I didn't realized in case of error we didn't return the error. Would not be better to return the error instead of empty tag/index?
Contributor
Author
There was a problem hiding this comment.
Yes, makes sense. In this PR or a separate one?
Contributor
There was a problem hiding this comment.
I can do it in a follow up PR I just finished what I was working on so I can tackle it 👍
…ted models Signed-off-by: Dorin Geman <dorin.geman@docker.com>
8819985 to
c2777fd
Compare
ilopezluna
approved these changes
Jul 10, 2025
This was referenced Jul 10, 2025
doringeman
added a commit
to docker/model-runner
that referenced
this pull request
Sep 23, 2025
…ted models (docker/model-distribution#107) Signed-off-by: Dorin Geman <dorin.geman@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From docker/model-runner#100 (comment).
Return structured response for untagged and deleted models.
docker/model-runner#100 and docker/model-cli#122 will require small changes once this PR is merged.
Without the required changes in the model-cli, this is the response I see: