Conversation
ericcurtin
approved these changes
Sep 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for custom chat templates in the llamacpp backend by enabling the use of chat template files from model bundles.
Key changes:
- Adds chat template file support to the llamacpp backend configuration
- Updates the argument generation logic to include
--chat-template-fileparameter when available - Updates model-distribution dependency to a newer version
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/inference/backends/llamacpp/llamacpp_config.go | Implements chat template file argument handling in completion mode |
| pkg/inference/backends/llamacpp/llamacpp_config_test.go | Adds test coverage for chat template functionality and updates test bundle |
| go.mod | Updates model-distribution dependency version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Emily Casey <emily.casey@docker.com>
Signed-off-by: Emily Casey <emily.casey@docker.com>
Signed-off-by: Emily Casey <emily.casey@docker.com>
xenoscopic
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the model runtime bundle contains a chat template file, use it by passing it to
llama.cppwith the--chat-templateflag. See CLI PR for usage example.Related PRs: