Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Golang and Alpine version #36

Closed
wants to merge 1 commit into from
Closed

Bump Golang and Alpine version #36

wants to merge 1 commit into from

Conversation

LaurentGoderre
Copy link
Member

No description provided.

whalelines
whalelines reviewed Aug 7, 2024
View reviewed changes
Copy link

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have the results of these changes been tested?

@tianon-sso
Copy link
Member

Yes, there's a smoke test in this repository that runs the full upstream test suite and some basic signing flows with Docker-in-Docker: https://github.com/docker/notary-official-images/blob/d1a94cf525b59aa7452a436d7cdc3d65f2a64fd8/.test/test.sh

tianon
tianon approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving here too, just in case this account has merge access 👀

@whalelines whalelines mentioned this pull request Aug 7, 2024
Merged
@tianon tianon mentioned this pull request Sep 6, 2024
Open
@tianon
Copy link
Contributor

tianon commented Sep 6, 2024

I've opened an updated alternative to this in #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whalelines whalelines whalelines left review comments

@tianon-sso tianon-sso tianon-sso approved these changes

@tianon tianon tianon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LaurentGoderre @tianon-sso @tianon @whalelines