Client should fall back on cache if operating offline when updating #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riyazdf
approved these changes
Sep 30, 2016
| @@ -5,6 +5,7 @@ | |||
| + Output message to CLI when repo changes have been successfully published [#974](https://github.com/docker/notary/pull/974) | |||
| + Improved error messages for client authentication errors and for the witness command [#972](https://github.com/docker/notary/pull/972) | |||
| + Support for finding keys that are anywhere in the notary directory's "private" directory, not just under "private/root_keys" or "private/tuf_keys" [#981](https://github.com/docker/notary/pull/981) | |||
| + Previously, on any error updating, the client would fall back on the cache. Now we only do so if there is a network error or if the server is unavailable or missing the TUF data (and fails on invalid root rotation). [#982](https://github.com/docker/notary/pull/982) | |||
There was a problem hiding this comment.
Can we split out the parenthesized bit for clarity? Something like Invalid TUF data will cause the update to fail, for example if there was an invalid root rotation
| } | ||
| defer resp.Body.Close() | ||
| return translateStatusToError(resp, "POST "+name) | ||
| return s.SetMulti(map[string][]byte{name: blob}) |
There was a problem hiding this comment.
this is an awesome cleanup 👍
| defer os.RemoveAll(tempBaseDir) | ||
| offlineRepo, err := NewNotaryRepository(tempBaseDir, "docker.com/notary", "https://nope", | ||
| nil, passphrase.ConstantRetriever("pass"), trustpinning.TrustPinConfig{}) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Should we call offlineRepo.Update(false) and verify that it errors?
There was a problem hiding this comment.
Oops, yes I was intending to and just forgot. :) Thanks!
cyli
force-pushed
the
update-uses-cache-if-offline
branch
2 times, most recently
from
ec8d772
to
2b3cac2
Compare
|
Please sign your commits following these rules: $ git clone -b "update-uses-cache-if-offline" git@github.com:cyli/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~74
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Ying Li <ying.li@docker.com>
Signed-off-by: Ying Li <ying.li@docker.com>
cyli
force-pushed
the
update-uses-cache-if-offline
branch
from
2b3cac2
to
95593e5
Compare
endophage
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client is in offline mode, or encounters some kind of network error when downloading a new timestamp, it should fall back on using the version of the repo in the cache.
Since there a huge number of possible network errors, just wrap any errors received when actually making the HTTP request using the remote store in a
NetworkError.