Bump notary version to 0.4.2 #27074
Merged
Bump notary version to 0.4.2 #27074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @riyazdf @endophage |
|
SGTM |
|
LGTM! |
|
^sorry, fixed an error message typo in two of the tests |
|
LGTM |
1 similar comment
|
LGTM |
|
bump. :) can this be merged? |
|
Looks like some related commits could be squashed, or are we good with having them all separate? |
|
@thaJeztah I have no strong feelings. I can squash them if you like. |
Signed-off-by: cyli <cyli@twistedmatrix.com>
- some function signatures have changed - use the new ones - re-generate the notary delegation key certs, since notary doesn't allow SHA1 - fix some error message mapping because now if a root rotation fails to validate trusted operations will fail Signed-off-by: cyli <cyli@twistedmatrix.com>
|
@cyli perhaps split in "bump" commits and "fix" commits |
|
oh! done already, haha |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Bump notary version to 0.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the notary dependency up to 0.4.2 (full changelogs here).
The docker-client-relevant behavior changes are:
~/.docker/trust/privatedirectory, not just under~/.docker/trust/private/root_keysor ``~/.docker/trust/private/tuf_keys` #981cc @riyazdf @endophage