append nodes to builder support #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
append
branch
7 times, most recently
from
19925f3
to
0ca207d
Compare
This was referenced Sep 20, 2022
crazy-max
force-pushed
the
append
branch
4 times, most recently
from
4bb5511
to
98b183b
Compare
crazy-max
force-pushed
the
append
branch
2 times, most recently
from
89c8889
to
d7946f2
Compare
tonistiigi
reviewed
Oct 12, 2022
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
|
@tonistiigi Should be good |
tonistiigi
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #115
needs #162 #163 #164adds
appendinput to be able to append additional nodes to the builder that is going to be created in the form of a YAML string document to remove limitations intrinsically linked to GitHub Actions (only string format is supported in the input fields) with the following fields:nameendpointdriver-optsbuildkitd-flagsplatformsalso adds
platformsinput to set fixed platforms for the first node when builder is created and be aligned withappend.