Return error if ports are specified in dnsrr mode #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We discussed this through slack with @mavenugo |
marcosnils
changed the title
Current coverage is 54.97% (diff: 100%)@@ master #1207 diff @@
==========================================
Files 77 77
Lines 12257 12259 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6744 6739 -5
- Misses 4591 4593 +2
- Partials 922 927 +5
|
| }, | ||
| }, | ||
| }) | ||
| assert.Error(t, err) |
There was a problem hiding this comment.
Check that the error contains ports can't be used with dnsrr mode.
There was a problem hiding this comment.
I don't see that other tests validate error messages. I've seen this though
assert.Equal(t, codes.InvalidArgument, grpc.Code(err))
Should I add that check as well?
Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
|
@aaronlehmann done. |
|
LGTM |
1 similar comment
|
LGTM |
|
@marcosnils |
|
@mrjana Given that routing-mesh performs opinionated port-based LB & it is not a generic network to be used for other purposes, I think we should remove this restriction & let the user use DNS-RR for back-end networks. wdyt ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcos Lilljedahl marcosnils@gmail.com