Return error if ports are specified in dsnrr mode

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>

manager/controlapi/service.go

@@ -145,6 +145,10 @@ func validateEndpointSpec(epSpec *api.EndpointSpec) error {
 		return nil
 	}
 
+	if len(epSpec.Ports) > 0 && epSpec.Mode == api.ResolutionModeDNSRoundRobin {
+		return grpc.Errorf(codes.InvalidArgument, "EndpointSpec: ports can't be used with dnsrr mode")
+	}
+
 	portSet := make(map[api.PortConfig]struct{})
 	for _, port := range epSpec.Ports {
 		if _, ok := portSet[*port]; ok {

manager/controlapi/service_test.go

@@ -436,6 +436,18 @@ func TestRemoveService(t *testing.T) {
 	assert.NotNil(t, r)
 }
 
+func TestValidateEndpointSpec(t *testing.T) {
+	err := validateEndpointSpec(&api.EndpointSpec{
+		Mode: api.ResolutionModeDNSRoundRobin,
+		Ports: []*api.PortConfig{
+			{
+				Name: "http", TargetPort: 80,
+			},
+		},
+	})
+	assert.Error(t, err)
+}
+
 func TestServiceEndpointSpecUpdate(t *testing.T) {
 	ts := newTestServer(t)
 	spec := &api.ServiceSpec{