Travis CI: fix libboost package issue #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredgrubb
force-pushed
the
jgrubb-travis-boost
branch
4 times, most recently
from
6754beb to
88b648b
Compare
jaredgrubb
force-pushed
the
jgrubb-travis-boost
branch
from
88b648b to
99d81d5
Compare
…ions The old Travis file had gcc-4.8 + boost::regex. But I think the default Ubuntu install (and the pre-packaged libboost_regex.so) was compiled against libstdc++-5 which had a major ABI break with std::string, which caused an ABI problem when gcc-4.8 was linking aginst that library. Easiest thing is to stop testing gcc-4.8 Also updated the clang and gcc versions to try newer ones.
jaredgrubb
force-pushed
the
jgrubb-travis-boost
branch
from
6414e6e to
556965c
Compare
Closed
|
Looks good to me. Two suggestions/comments:
|
Closed
|
Cleaner to link boost using CMake? Not sure what you mean? A MSVC check would be nice, as their stuff is subtly different. |
tdegeus
reviewed
Nov 29, 2019
| CMAKE_OPTIONS+=" -DBoost_REGEX_LIBRARY_DEBUG=/usr/lib/x86_64-linux-gnu/libboost_regex.so.1.55.0" | ||
| CMAKE_OPTIONS+=" -DBoost_REGEX_LIBRARY_RELEASE=/usr/lib/x86_64-linux-gnu/libboost_regex.so.1.55.0" | ||
| CMAKE_OPTIONS+=" -DBoost_REGEX_LIBRARY_DEBUG=/usr/lib/x86_64-linux-gnu/libboost_regex.so" | ||
| CMAKE_OPTIONS+=" -DBoost_REGEX_LIBRARY_RELEASE=/usr/lib/x86_64-linux-gnu/libboost_regex.so" |
There was a problem hiding this comment.
It could be cleaner to do the linking inside the CMakeLists.txt. This could would also be simpler to port this file to appveyor
There was a problem hiding this comment.
Though it is a secondary issue that could be solved in a separate PR.
There was a problem hiding this comment.
These are defines that tell CMake where it can look for the installed boost libraries; this is specific to Travis so this would not belong to the CMake file (although I am curious why this is needed at all; open to additional futzing around on this in new PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix part of #119