Revert "Fix: ready/doneEach order with async afterEach (#1770)"

This reverts commit 076d084.
docsifyjs · Oct 26, 2022 · 8dd9160 · 8dd9160
1 parent 9339382
commit 8dd9160
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/core/render/index.js b/src/core/render/index.js
@@ -321,15 +321,15 @@ export function Render(Base) {
             );
           }
 
-          this.callHook('afterEach', html, hookData => {
-            renderMain.call(this, hookData);
-            next();
-          });
+          this.callHook('afterEach', html, hookData =>
+            renderMain.call(this, hookData)
+          );
         };
 
         if (this.isHTML) {
           html = this.result = text;
           callback();
+          next();
         } else {
           prerenderEmbed(
             {
@@ -339,6 +339,7 @@ export function Render(Base) {
             tokens => {
               html = this.compiler.compile(tokens);
               callback();
+              next();
             }
           );
         }

diff --git a/test/e2e/plugins.test.js b/test/e2e/plugins.test.js
@@ -9,7 +9,7 @@ test.describe('Plugins', () => {
       'mounted',
       'beforeEach-async',
       'beforeEach',
-      'afterEach-async',
+      // 'afterEach-async',
       'afterEach',
       'doneEach',
       'ready',
@@ -41,12 +41,13 @@ test.describe('Plugins', () => {
               return markdown;
             });
 
-            hook.afterEach(function (html, next) {
-              setTimeout(function () {
-                console.log('afterEach-async');
-                next(html);
-              }, 100);
-            });
+            // FIXME: https://github.com/docsifyjs/docsify/issues/449
+            // hook.afterEach(function (html, next) {
+            //   setTimeout(function () {
+            //     console.log('afterEach-async');
+            //     next(html);
+            //   }, 100);
+            // });
 
             hook.afterEach(function (html) {
               console.log('afterEach');