Skip to content

mobile site scrolls sideways now #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
trusktr opened this issue Jun 13, 2020 · 7 comments
Closed
1 task

mobile site scrolls sideways now #1219

trusktr opened this issue Jun 13, 2020 · 7 comments
Labels
bug confirmed as a bug regression

Comments

@trusktr
Copy link
Member

trusktr commented Jun 13, 2020

Bug Report

The mobile site scrolls horizontally a little bit. (This is not published yet)

The current live site at docsify.js.org does not have this bug yet.

Steps to reproduce

go to mobile mode and try scrolling horizontally:

What is current behaviour

scroll-sideways

What is the expected behaviour

does not scroll sideways:

no-scroll-sideways

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Linux

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version: develop

  • Docsify plugins: whatever the docsify site has

Please create a reproducible sandbox

https://docsify-preview-git-fork-mlh-fellowship-1213-fix-sidebar-toggle.docsify-core.vercel.app/#/

Mention the docsify version in which this bug was not present (if any)

@trusktr trusktr added bug confirmed as a bug regression labels Jun 13, 2020
@anikethsaha
Copy link
Member

Can we fix this in #1215 itself ?

@jhildenbiddle
Copy link
Member

jhildenbiddle commented Jun 13, 2020

Strange. I'm not seeing this behavior on iPhone (XS Max) or iPad.

@trusktr -- Which device(s) are you testing on?

@mohammedsahl
Copy link
Contributor

mohammedsahl commented Jun 13, 2020

Can we fix this in #1215 itself ?

Yeah definitely. I have a few questions though. Was this caused after merging in #1215 in anyway? And what device is this problem occurring on? I've tested all the ones Chrome devtools has to offer

image

EDIT: Was it caused because the page was zoomed in, causing side scrolling to be enabled?

@jhildenbiddle
Copy link
Member

Possibly related (since I'm not seeing this scroll issue either): #1215 (comment)

@trusktr
Copy link
Member Author

trusktr commented Jun 19, 2020

Which device(s) are you testing on?

Chrome mobile emulation (in Linux) but not on Android. Hmmmm...

Was this caused after merging in #1215 in anyway?

I don't think it was.

@jhildenbiddle
Copy link
Member

FWIW, I'm not seeing this behavior on iOS (real device) or the Chrome emulator.

@trusktr -- Are you looking at docsify.js.org (v4.11.4)? I ask because the screenshots show 4.11.3.

@trusktr
Copy link
Member Author

trusktr commented Jun 24, 2020

At the moment I'm not seeing this on docsify.js.org. I'll re-open if I see it again.

@trusktr trusktr closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug regression
Projects
None yet
Development

No branches or pull requests

4 participants