Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Plugin doesn't indexes text inside a bulleted and numbered list #1366

Closed
1 task done
Nipun-Suradkar opened this issue Sep 2, 2020 · 1 comment · Fixed by #1361
Closed
1 task done

Search Plugin doesn't indexes text inside a bulleted and numbered list #1366

Nipun-Suradkar opened this issue Sep 2, 2020 · 1 comment · Fixed by #1361
Labels
bug confirmed as a bug

Comments

@Nipun-Suradkar
Copy link

Nipun-Suradkar commented Sep 2, 2020 •
edited
Loading

Bug Report

The Docsify search plugin is not able to create proper indexes of test under a bulleted and numbered list. So we are not able to search for the text in these lists using docsify search plugin.

Steps to reproduce

index.html :

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <title>Document</title>
  <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1" />
  <meta name="description" content="Description">
  <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
  <link rel="stylesheet" href="//cdn.jsdelivr.net/npm/docsify/lib/themes/vue.css">
</head>
<body>
  <div id="app"></div>
  <script>
    window.$docsify = {
      loadSidebar: true,
      search: {
        paths: 'auto',
        placeholder: 'Search',
      }
    }
  </script>
  <script src="//cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js"></script>
  <script src="//cdn.jsdelivr.net/npm/docsify/lib/plugins/search.min.js"></script>
</body>
</html>

README.md

# Bulleted and Numbered List

## Bulleted List
* No statically built html files
* Simple and lightweight
* Smart full-text search plugin
* Multiple themes

## Numbered List
1. Useful plugin API
2. Emoji support
3. Compatible with IE11
4. Support server-side rendering (example)


## Example.com
This domain is for use in illustrative examples in documents. You may use this domain in literature without prior coordination or asking for permission.

What is current behaviour

docsify.search.index :

bug

As we can see the docsify.search.index has no body key inside the #/README?id=bulleted-list and #/README?id=numbered-list . Thus we can't search for text inside those lists

What is the expected behaviour

We should be able to search for text inside Bulleted and Numbered List.

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Ubuntu 18.04

  • Node.js version: 12.16.1

  • npm/yarn version: 6.14.8

  • Browser version: Chrome 83

  • Docsify version: 4.4.1

  • Docsify plugins: search

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)
@sy-records sy-records linked a pull request Sep 2, 2020 that will close this issue
fix: search cannot search list content #1361
Merged
19 tasks
@sy-records sy-records added the bug confirmed as a bug label Sep 2, 2020
@sy-records
Copy link
Member

Thank you for your feedback, we are aware of this issue and will fix it in the next version. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed as a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: search cannot search list content sy-records/docsify
2 participants
@Nipun-Suradkar @sy-records