-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dependency Notification] Upgrade marked which may gonna drop support IE11. #1885
Comments
Will the code help you? <script src="https://cdn.jsdelivr.net/npm/marked@4"></script>
<script>
let newMarked = marked; // I find that marked will be overwritten by Docsify, so save it before
window.$docsify={
markdown: (originMarked, originRenderer) => newMarked.parse // markdown: newMarked.parse
};
</script> I saw it from upupming/docsify-katex#36. I think replacing 'marked' with 'marked.parse' will help the latest marked work well in Docsify. // Docsify library source code
import {marked.parse as marked} from marked // the newest version |
I can prove Docsify will use the latest marked to parse markdown because the built-in marked doesn't support the extension, but the newer one does, which helps me to parse math formula |
Hi @dzylikecode, thx for those info. |
You know more than me. Professional things should be left to professional people. I just offer what I see to you. 😏 😏 😏 |
That's a nice trick. We should document that trick, perhaps here: https://docsify.js.org/#/configuration?id=markdown |
Summary
This issues is for tracing marked and related dependencies upgrade.
As per to current incompatible and related dependencies outdated, the marked js upgrade stuff is tough to move on.
For avoiding the vulnerabilities issues, we should upgrade mark js asap.
Update
We update
marked.js
to 4.2.12 and make some changes to fix the upgrade issue in #1993 .In case of the unpredicted issue for this change, the parser breaking especially.
Hold this issue thread to trace and collect report of the marked issue.
Breaking
Maybe not support the IE11 from the next release since
marked.js
removed the support of IE11. 💣Related PR:
#1503
#1993
The text was updated successfully, but these errors were encountered: