Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Style code improvements #2112

Closed
4 tasks
trusktr opened this issue Jul 3, 2023 · 1 comment · Fixed by #2469
Closed
4 tasks

CSS Style code improvements #2112

trusktr opened this issue Jul 3, 2023 · 1 comment · Fixed by #2469
Assignees
Milestone

Comments

@trusktr
Copy link
Member

trusktr commented Jul 3, 2023

This is a new issue to track the improvements to the CSS styling system. This will likely be a major version bump on its own eventually, but first we can see if there's a way we can deprecate existing style vars for a while before we remove them in a major bump.

  • Prefix all Docsify CSS variables with --docsify-. For example, --theme-color should be --docsify-theme-color, or even better --docsify-accent-color.
  • Deprecate old variables, but keep them around for back compat for a while.
    • We can, for example, map a new --docsify-accent-color variable to the existing --theme-color once we deprecate it, then eventually we remove --theme-color and use --docsify-accent-color directly.
    • We can write a script that checks style sheets for deprecated variables, and warns in console.
  • Let's update styling code so that docsify-themeable implementation becomes simpler, if possible. (cc @jhildenbiddle)
  • ...
@anniepauline
Copy link

I'd like to work on it.Is it up for grabs?

@jhildenbiddle jhildenbiddle added this to the 5.x milestone Jun 16, 2024
@jhildenbiddle jhildenbiddle self-assigned this Jun 16, 2024
@jhildenbiddle jhildenbiddle linked a pull request Jul 19, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants