Skip to content

Accessibility - current page in sidebar should have aria-current="page" #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kburk1997 opened this issue Sep 12, 2023 · 1 comment · Fixed by #2254
Closed

Accessibility - current page in sidebar should have aria-current="page" #2226

kburk1997 opened this issue Sep 12, 2023 · 1 comment · Fixed by #2254
Assignees

Comments

@kburk1997
Copy link

Feature request

Problem or desire

Currently, screen readers such as VoiceOver, JAWS, or NVDA cannot differentiate between selected and non-selected links.

Proposal

Use aria-current="page" on the selected link, and leave non-selected links as-is

Implementation

DOM tree:
Screenshot of DOM tree with active link highlighted. Active link has aria-current="page"

VoiceOver screen recordings:

Without aria-current:

Screen.Recording.2023-09-12.at.11.43.55.AM.mov

With aria-current:

Screen.Recording.2023-09-12.at.11.37.30.AM.mov

Reference: MDN - aria-current

@jhildenbiddle
Copy link
Member

jhildenbiddle commented Oct 17, 2023

Thanks for creating the issue, @kburk1997!

I've created a draft PR here: #2254. In that PR you will find a preview link which will allow you to review the changes:

CleanShot 2023-10-17 at 08 59 27@2x

Before I mark this PR as ready for review by the maintainers, I would love to get your thoughts and/or feedback.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants