Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Change 'X' button style #2287

Closed
singodiyashubham87 opened this issue Oct 21, 2023 · 2 comments
Closed

Feature: Change 'X' button style #2287

singodiyashubham87 opened this issue Oct 21, 2023 · 2 comments
Assignees
@jhildenbiddle
Milestone
5.x

Comments

@singodiyashubham87
Copy link

Feature request

Problem or desire

The size of the 'x' button near the search should have to be a little larger to be more consistent with the UI

Proposal

I will either scale it up a little bit or change the whole icon itself.

Implementation

To implement this, I'll change the styling of the button.

image
@Koooooo-7
Copy link
Member

Hi @singodiyashubham87 , It seems not our official style, do you use some theme or custom styles?
If you could provide a demo site/codebase would be better.

@jhildenbiddle jhildenbiddle added this to the 5.x milestone Mar 2, 2024
@jhildenbiddle jhildenbiddle self-assigned this Mar 2, 2024
jhildenbiddle added a commit that referenced this issue Jun 21, 2024
@jhildenbiddle
Update search plugin button
fc94626 
- Replace SVG wtih CSS-only styling
- Add custom properties for customization
- Refactor clear search event listener
- Fix sidebar element spacing

Fix #528
Fix #2287
@jhildenbiddle jhildenbiddle mentioned this issue Jul 18, 2024
Merged
6 tasks
@jhildenbiddle
Copy link
Member

This issue has been addressed by PR #2469. The changes will be available when Docsify v5 is released.

CleanShot 2024-07-19 at 11 43 04@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhildenbiddle jhildenbiddle

Labels
None yet
Projects
None yet
Milestone
5.x
Development

No branches or pull requests
3 participants
@jhildenbiddle @Koooooo-7 @singodiyashubham87