Skip to content

Sidebar button does not have a description useful for screen reader users #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrapetronela opened this issue Oct 29, 2018 · 4 comments · Fixed by #2254
Closed

Sidebar button does not have a description useful for screen reader users #658

andrapetronela opened this issue Oct 29, 2018 · 4 comments · Fixed by #2254

Comments

@andrapetronela
Copy link

Accessibility test errors

screenshot 143

It would be nice to have an aria-label attribute that will help screen reader users understand what action will perform the button.
Without an aria-label attribute:

  • the sidebar button is identified by the screen readers only as a button element
  • impossible to the user to know what action will perform the button, once clicked / selected

aria-label has no effect on browsers. It only helps assistive technology attach a label to an HTML element.

@cheng-kang
Copy link
Contributor

This is definitely a thing to be added. Would be best if you could make some suggestions about the labels 😄

@andrapetronela
Copy link
Author

  • <button aria-label="Toggle sidebar">
  • <input aria-label="Search through site content">

What do you think, @cheng-kang? :)

@chris-79
Copy link

Bump

We need this

@jhildenbiddle
Copy link
Member

Thanks for creating the issue and for your patience white waiting for it to be addressed, @andrapetronela.

I've created a draft PR here: #2253. In that PR you will find a preview link which will allow you to review the changes:

CleanShot 2023-10-17 at 08 59 27@2x

Before I mark this PR as ready for review by the maintainers, I would love to get your thoughts and/or feedback.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants