fix(embed): fix multiple embeds (#1078)

[madhavarshney]

Summary

After many hours of debugging 😅 , I found that marked mutates the tokens array that we pass directly, breaking the logic in prerenderEmbed for multiple embeds. This PR fixes #1078.

See this in marked.

docsify/src/core/render/index.js

Lines 169 to 180 in 2048610

	prerenderEmbed(
	{
	compiler: this.compiler,
	raw: result,
	},
	tokens => {
	html = this.compiler.compile(tokens);
	html = this.isRemoteUrl ? DOMPurify.sanitize(html) : html;
	callback();
	next();
	}
	);

Also, this may fix #791, though I haven't tested that yet.

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Repo settings
• Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

• Chrome
• Firefox
• Safari
• Edge
• IE

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated
• Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/b4flyaf2n
✅ Preview: https://docsify-preview-git-fork-madhavarshney-fix-embed-multiple.docsify-core.vercel.app

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3cca7cb:

Sandbox	Source
docsify-template	Configuration

[madhavarshney]

IMO all this cloning here is a bit odd... 😄

[sy-records]

Looks good, can you add some tests? 👍🏻

[madhavarshney]

I'm currently a bit busy, so if anyone would like to add some tests, then go ahead! Otherwise, I'll try to do it soon (hopefully near the end of this week).

[anikethsaha]

Thanks for the PR.

@madhavarshney take your time , no hurry at all. You can also convert this to draft if its ok by you in order to let others know that this is still WIP

[anikethsaha]

Need tests for this rest its ok.

[sy-records]

Waiting to add a test

[madhavarshney]

This has been fixed with the upgrade to marked.js.