-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : add patch for {docsify-ignore} and {docsify-ignore-all} #1351
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/kquxak60d |
…ments This reverts commit 90d283d
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 204bfbb:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the <!-- {docsify-ignore} -->
and also let the {docsify-ignore}
work fine, in case of causing the second breaking for users who may already use the new option.
I agree with @Koooooo-7 if we can manage to to ship the changes it would be great. |
@anikethsaha @Koooooo-7 Done. In #1318, I had a reference to the need for compatibility. #1318 (review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: when and how we will solve it.
Awaiting @trusktr and @jhildenbiddle approval, release v4.11.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. For later, we can revert the PR merge commit to re-create these changes. We can open a PR with the changes, and just keep it open for v5 until we're ready.
Should we revert the removal of |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! This is good, to keep both forms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Looks good! Let's get this in.
@trusktr Do we have to wait for @jhildenbiddle ? Or can we merge and release patch versions now? |
Summary
<!-- {docsify-ignore} -->
is a major change and should be put into v5.But a version has already been released, so a patch version has been added that is compatible with older versions and can be removed in v5.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.