refactor: refactoring `hideSidebar` configuration. #1396

Koooooo-7 · 2020-10-13T11:32:47Z

Refactor hideSidebar that removing the tpl of sidebar (if hideSidebar : true).
Checking the hideSidebar when having options on sidebar.

Summary

What kind of change does this PR introduce? (check at least one)

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

Yes
No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

If adding a new feature, the PR's description includes:

A convincing reason for adding this feature
Related documents have been updated
Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

vercel · 2020-10-13T11:32:54Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/3kbn0qg3v
✅ Preview: https://docsify-preview-git-refactor-holdsidebar.docsify-core.vercel.app

codesandbox-ci · 2020-10-13T11:34:48Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ac291e:

Sandbox	Source
docsify-template	Configuration

anikethsaha

This is a much better approach than the current one.

cc @sy-records , this will fix #1392 as well.

anikethsaha

Can you write tests for this if possible ?

Koooooo-7 · 2020-10-13T12:14:28Z

Can you write tests for this if possible ?

yup, I will check the test tutorial and try to get a new test. 😅

…ocsify into refactor-holdSidebar

Koooooo-7

Add test and we may add more tests of configurations here.
The CI issues cuz the test site includes search plugin to cause the error.

src/plugins/search/search.js

sy-records · 2020-10-14T09:58:51Z

    TypeError: Cannot read property 'insertBefore' of null

      163 | 
      164 |   function before(target, el) {
    > 165 |     return target.insertBefore(el, target.children[0]);
          |                   ^
      166 |   }
      167 | 
      168 |   function on(el, type, handler) {

Error due to docsify-plugin-carbon plugin, @waruqi Can you fix it in your plugin?

* fix: Can't search homepage content * fix: when pathNamespaces does not exist * add test * update test to fix windows ci

Koooooo-7 · 2020-10-15T07:04:00Z

@waruqi thx ur input ! IMHO, literally, it is not ur duty to make the plugin which is based on sidebar to suit the no sidebar case, it seems awkward.
@sy-records As I mentioned, it is not the carbon plugin caused some err, could u provide any information about it ?

Koooooo-7 · 2020-10-15T12:10:34Z

cc @anikethsaha @sy-records I fixed the CI issue, review it again plz.

sy-records · 2020-10-16T00:28:24Z

src/core/render/index.js

-      document.querySelector('section.content').style.right = 'unset';
-      document.querySelector('section.content').style.left = 'unset';
-      document.querySelector('section.content').style.position = 'relative';
-      document.querySelector('section.content').style.width = '100%';


@anikethsaha Should we keep the style?

develop branch

now

I think we can just keep this configurations without adjusting much styles right now （dont let render code including much styles）, and if there has much users proposal to make it that we can refine it again.
WDYT?

I think we should keep them and not change them in the z versions.

Koooooo-7 · 2020-10-16T00:42:17Z

Please check the console for some errors

Plz Checking the exception again and make sure how it is reproducible and what it is blame for.FYI. If you just found something wrong/exception without catching the point, it would be useless.

sy-records · 2020-10-16T00:44:09Z

Add hideSidebar: true, to index.html to reproduce.

Koooooo-7 · 2020-10-16T00:46:50Z

@sy-records sorry, I can't make it reproducible, could u please do me a favor that checking about it.

sy-records · 2020-10-16T00:51:20Z

Well, ignore it. I can't reproduce it either.

Koooooo-7 · 2020-10-16T01:02:37Z

Well, ignore it.

what does the ignore mean? if there were an issue, we should figure it out to make our site changes and test reliable.

jhildenbiddle · 2022-03-20T14:48:51Z

@Koooooo-7 --

Is this PR still worth considering or should we close it? I admit to not reviewing it due to the age, but I'm happy to if you'd like me to.

Koooooo-7 · 2022-03-21T04:21:51Z

@Koooooo-7 --

Is this PR still worth considering or should we close it? I admit to not reviewing it due to the age, but I'm happy to if you'd like me to.

It seems outdate, I'd like to close it for now,

Koooooo-7 added 2 commits October 13, 2020 19:20

[refactor] hideSidebar.

9c37c5c

[update docs] rt.

676f13a

Koooooo-7 requested review from trusktr, jhildenbiddle, anikethsaha and sy-records October 13, 2020 11:32

vercel bot deployed to Preview October 13, 2020 11:32 View deployment

anikethsaha approved these changes Oct 13, 2020

View reviewed changes

anikethsaha requested changes Oct 13, 2020

View reviewed changes

sy-records linked an issue Oct 14, 2020 that may be closed by this pull request

Hidden sidebar causing other plugins issues #1392

Closed

1 task

Koooooo-7 added 4 commits October 14, 2020 16:19

[refactor] hideSidebar.

cfe1fa8

[update docs] rt.

3e7f27d

add test.

6368d65

Merge branch 'refactor-holdSidebar' of https://github.com/Koooooo-7/d…

efb645d

…ocsify into refactor-holdSidebar

vercel bot deployed to Preview October 14, 2020 09:34 View deployment

snyc.

170f6f7

vercel bot deployed to Preview October 14, 2020 09:36 View deployment

refine.

64261b2

vercel bot deployed to Preview October 14, 2020 09:39 View deployment

Koooooo-7 commented Oct 14, 2020

View reviewed changes

sy-records requested changes Oct 14, 2020

View reviewed changes

src/plugins/search/search.js Outdated Show resolved Hide resolved

snyc.

45d1a12

vercel bot deployed to Preview October 14, 2020 09:48 View deployment

Koooooo-7 requested review from anikethsaha and sy-records October 14, 2020 09:48

anikethsaha previously approved these changes Oct 14, 2020

View reviewed changes

fix: Can't search homepage content (docsifyjs#1391)

9bfac00

* fix: Can't search homepage content * fix: when pathNamespaces does not exist * add test * update test to fix windows ci

Koooooo-7 dismissed anikethsaha’s stale review via 9bfac00 October 15, 2020 03:29

vercel bot deployed to Preview October 15, 2020 03:29 View deployment

Koooooo-7 requested review from anikethsaha and sy-records October 15, 2020 03:29

vercel bot deployed to Preview October 15, 2020 03:51 View deployment

may fix CI.

23c44ee

Koooooo-7 force-pushed the refactor-holdSidebar branch from f3709ec to 23c44ee Compare October 15, 2020 06:58

vercel bot deployed to Preview October 15, 2020 06:59 View deployment

Koooooo-7 requested review from anikethsaha and removed request for anikethsaha October 15, 2020 07:04

Merge branch 'develop' into refactor-holdSidebar

4b4f4d2

vercel bot deployed to Preview October 15, 2020 09:46 View deployment

Merge branch 'develop' into refactor-holdSidebar

27e497e

vercel bot deployed to Preview October 15, 2020 11:41 View deployment

anikethsaha approved these changes Oct 15, 2020

View reviewed changes

sy-records requested changes Oct 16, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'develop' into refactor-holdSidebar

2ac291e

vercel bot deployed to Preview October 22, 2020 00:32 View deployment

Koooooo-7 closed this Mar 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: refactoring `hideSidebar` configuration. #1396

refactor: refactoring `hideSidebar` configuration. #1396

Koooooo-7 commented Oct 13, 2020

vercel bot commented Oct 13, 2020 •

edited

Loading

codesandbox-ci bot commented Oct 13, 2020 •

edited

Loading

anikethsaha left a comment •

edited

Loading

anikethsaha left a comment •

edited

Loading

Koooooo-7 commented Oct 13, 2020

Koooooo-7 left a comment •

edited

Loading

sy-records commented Oct 14, 2020

Koooooo-7 commented Oct 15, 2020

Koooooo-7 commented Oct 15, 2020

sy-records Oct 16, 2020

Koooooo-7 Oct 20, 2020

sy-records Oct 22, 2020

This comment has been minimized.

Koooooo-7 commented Oct 16, 2020

sy-records commented Oct 16, 2020

Koooooo-7 commented Oct 16, 2020

sy-records commented Oct 16, 2020 •

edited

Loading

Koooooo-7 commented Oct 16, 2020

jhildenbiddle commented Mar 20, 2022 •

edited

Loading

Koooooo-7 commented Mar 21, 2022

refactor: refactoring hideSidebar configuration. #1396

refactor: refactoring hideSidebar configuration. #1396

Conversation

Koooooo-7 commented Oct 13, 2020

vercel bot commented Oct 13, 2020 • edited Loading

codesandbox-ci bot commented Oct 13, 2020 • edited Loading

anikethsaha left a comment • edited Loading

Choose a reason for hiding this comment

anikethsaha left a comment • edited Loading

Choose a reason for hiding this comment

Koooooo-7 commented Oct 13, 2020

Koooooo-7 left a comment • edited Loading

Choose a reason for hiding this comment

sy-records commented Oct 14, 2020

Koooooo-7 commented Oct 15, 2020

Koooooo-7 commented Oct 15, 2020

sy-records Oct 16, 2020

Choose a reason for hiding this comment

develop branch

now

Koooooo-7 Oct 20, 2020

Choose a reason for hiding this comment

sy-records Oct 22, 2020

Choose a reason for hiding this comment

This comment has been minimized.

Koooooo-7 commented Oct 16, 2020

sy-records commented Oct 16, 2020

Koooooo-7 commented Oct 16, 2020

sy-records commented Oct 16, 2020 • edited Loading

Koooooo-7 commented Oct 16, 2020

jhildenbiddle commented Mar 20, 2022 • edited Loading

Koooooo-7 commented Mar 21, 2022

refactor: refactoring `hideSidebar` configuration. #1396

refactor: refactoring `hideSidebar` configuration. #1396

vercel bot commented Oct 13, 2020 •

edited

Loading

codesandbox-ci bot commented Oct 13, 2020 •

edited

Loading

anikethsaha left a comment •

edited

Loading

anikethsaha left a comment •

edited

Loading

Koooooo-7 left a comment •

edited

Loading

sy-records commented Oct 16, 2020 •

edited

Loading

jhildenbiddle commented Mar 20, 2022 •

edited

Loading