Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent loading remote content via URL hash #1489

Merged
merged 6 commits into from
Feb 5, 2021

Conversation

jhildenbiddle
Copy link
Member

@jhildenbiddle jhildenbiddle commented Feb 5, 2021

Fixes #1477. Fixes #1126.

  1. Prevent loading remote content via URL hash
  2. Restore ability to execute remote content scripts

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Feb 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/cz9cvkbqj
✅ Preview: https://docsify-preview-git-fix-security-url-hash.docsify-core.vercel.app

@jhildenbiddle jhildenbiddle requested a review from a team February 5, 2021 00:51
@jhildenbiddle jhildenbiddle changed the title Prevent loading remote content via URL hash fix: Prevent loading remote content via URL hash Feb 5, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 561cf9d:

Sandbox Source
docsify-template Configuration

sy-records
sy-records previously approved these changes Feb 5, 2021
Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sy-records sy-records requested a review from a team February 5, 2021 01:29
@jhildenbiddle jhildenbiddle mentioned this pull request Feb 5, 2021
7 tasks
@sy-records sy-records mentioned this pull request Feb 5, 2021
3 tasks
@sy-records sy-records merged commit 14ce7f3 into develop Feb 5, 2021
@sy-records sy-records deleted the fix-security-url-hash branch February 5, 2021 05:56
jhildenbiddle added a commit that referenced this pull request Feb 14, 2021
Koooooo-7 pushed a commit that referenced this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Vulnerability vulnerability report
4 participants