Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the coverpage image display error #1514

Closed
wants to merge 10 commits into from
4 changes: 2 additions & 2 deletions src/themes/basic/_coverpage.styl
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ section.cover
opacity 0.8
position absolute
top 0
height 100%
width 100%
height 100vh
width 100vw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, due to how vw works, we need to verify that the page does not start scrolling sideways, because 100vw does not account for scrollbar width. See this:

https://stackoverflow.com/questions/23367345/100vw-causing-horizontal-overflow-but-only-if-more-than-one/23367686

Can you add screenshots in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added screenshots.


.cover-main
flex 1
Expand Down