-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved getAndRemoveConfig util function #1603
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/6tRYwHFmrfvrJ3WaBw3bWvvD3NW9 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 28aa079:
|
Thank you, Sorry, my branch was not updated to the latest commit, because I’m not at home. - Can’t rebase my branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good patch, Thanks
src/core/render/utils.js
Outdated
.replace(/^('|")/, '') | ||
.replace(/('|")$/, '') | ||
.replace(/^"(:.*)"$/, '$1') | ||
.replace(/^'(:.*)'$/, '$1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have the matching-quotes addition without the :
change. A separate PR for the :
could be saved for v5 (breaking change).
what should happen to this pr? |
Summary
Improved the getAndRemoveConfig until function to only parse a config if there is a colon on start.
I pushed this commit before I realized that my previous PR is already merged.
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
#1597
#1598
Tested in the following browsers: