fix: files from basePath should be remoteUrl:false #1660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the
basePath
as an absolute url including the domain and the domain ofindex.html
and the domain ofbasePath
are different, Currently, files fetched frombasePath
are treated asisExternal: true
, and I think this behavior is a bug.basePath
is a value that can be entered only with the authority of the document site administrator, and thebasePath
server can also be considered owned by the administrator, so theisRemoteUrl
value should befalse
.What kind of change does this PR introduce?
Bugfix
For any code change,
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
#1659
Tested in the following browsers: