Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing Vue support for Vercel builds #2134

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

trusktr
Copy link
Member

@trusktr trusktr commented Jul 16, 2023

Summary

We currently have two index.html files (why is that again?). One file was not loading Vue stuff.

Without the Vue support in Vercel builds, we were unable to fully verify pull request builds, therefore unable to confirm if Vue broke or not. Now we can manually check Vue functionality for PRs.

What kind of change does this PR introduce?

Add Vue support to the index.html file that didn't have it.

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel
Copy link

vercel bot commented Jul 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 10:03am

@Koooooo-7
Copy link
Member

Koooooo-7 commented Jul 18, 2023

Hi @trusktr , That's what I work on the 2 index.html sometimes.

One is /doc/index.html, which we could host it as docsify live site, which import external .../docsify@4/lib/docsify.min.js (we could check current live behavior).
One is /index.html, thats for the dev locally, which import /lib/docsify.js (we could check the dev/changed behavior).

We could have a compare on them easily.

Maybe we should sync common files index.html, README...on time in case of having some different except dev changes.

@sy-records sy-records disabled auto-merge July 18, 2023 10:31
@sy-records sy-records merged commit 63afa9c into develop Jul 18, 2023
6 checks passed
@sy-records sy-records deleted the fix-vue-in-vercel-deployments branch July 18, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants