-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade marked from 12.0.2 to 13.0.2 #2467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sy-records
changed the title
update: upgrade marked from 12.0.2 to 13.0.2 adoption
chore: upgrade marked from 12.0.2 to 13.0.2 adoption
Jul 18, 2024
jhildenbiddle
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Happy to see now tests or snapshots needed to be updated :).
sy-records
approved these changes
Jul 22, 2024
sy-records
changed the title
chore: upgrade marked from 12.0.2 to 13.0.2 adoption
chore: upgrade marked from 12.0.2 to 13.0.2
Jul 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the markedjs release to v13, all the
renderer
's params change to TOKENS instead of the pre versions' behaviors.So, we need manually build the contents as the default renderer of markedjs in pre versions to get
those contents which we need.
Refer
The default renderer impl of markedjs markedjs/Renderer.ts
The changes before the v13. markedjs/Instance.ts
The new params for each TOKEN. markedjs/Tokens.ts
close #2461
Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Yes
No
Tested in the following browsers: