Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct mermaid docs after upgrade marked #2490

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Conversation

Koooooo-7
Copy link
Member

Summary

correct mermaid docs after upgrade marked, and mentioned its limitation.
We should adoption the mermaid to resolve the async issue in #1433 then.

Related issue, if any:

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

Yes
No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 0:44am

Copy link
Collaborator

@paulhibbitts paulhibbitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Koooooo-7 , thanks so much for identifying this issue! I've been using the Mermaid plugin (https://github.com/Leward/mermaid-docsify which seems to support v10) so I did not even know of any support of Mermaid was possible in Docsify itself🙂

Happy to help tweak the updated docs, here is a first pass:

## Limited Support of mermaid

!> Currently, docsify only supports mermaid version `v9.3.0` (as the async render in mermaid `v10.x` is not yet supported in docsify)

I also have a preview build with this change for you to see:
https://paulhibbitts.github.io/docsify-v5-preview/#/markdown?id=limited-support-of-mermaid

And tried an example Mermaid 9.x diagram🙂
https://paulhibbitts.github.io/docsify-v5-preview/#/test-5

PS - I think I will also exploring moving over to this built-in support with Docsify-This

docs/markdown.md Outdated Show resolved Hide resolved
Copy link
Member

@trusktr trusktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just typo and adjustment and let's merge

@trusktr
Copy link
Member

trusktr commented Aug 16, 2024

Btw what happens with latest mermaid? Is there an error or something?

docs/markdown.md Outdated Show resolved Hide resolved
@sy-records sy-records changed the title chore(docs): correct mermaid docs after upgrade marked docs: correct mermaid docs after upgrade marked Aug 17, 2024
@Koooooo-7
Copy link
Member Author

Btw what happens with latest mermaid? Is there an error or something?

The mermaid makes a breaking change that it only support the async render after > v9.3, but we use the marked in synchronization. Hence user can not simply replace the code render with async functions, it gonna get a wrong Promised.

@Koooooo-7 Koooooo-7 requested a review from trusktr August 17, 2024 06:03
@paulhibbitts paulhibbitts self-requested a review August 17, 2024 17:41
Copy link
Collaborator

@paulhibbitts paulhibbitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Koooooo-7 Koooooo-7 merged commit e204ac6 into develop Aug 18, 2024
9 checks passed
@Koooooo-7 Koooooo-7 deleted the fix-doc-01 branch August 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants