Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] [Issue #486] Local storage is now stored per hostname (for subdomains) #496

Closed
wants to merge 1 commit into from

Conversation

dmed256
Copy link

@dmed256 dmed256 commented May 20, 2018

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@dmed256
Copy link
Author

dmed256 commented May 20, 2018

Oops, misread the issue...
I think instead of window.location.hostname it needs to use config.basePath

@dmed256 dmed256 changed the title [Issue #486] Local storage is now stored per hostname (for subdomains) [DO NOT MERGE] [Issue #486] Local storage is now stored per hostname (for subdomains) May 20, 2018
@yinheli
Copy link

yinheli commented Jun 26, 2018

It is not applicable with one domain with multi docsify instance.
Why not add search key prefix for config? #553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants