Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontmatter: Move frontmatter content into vm.frontmatter #551

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

petrjoachim
Copy link
Contributor

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

Switching frontmatter config from vm.config to separate vm.frontmatter solves cross-polluting when going from page with frontmatter to page without it.

Also switching from attributes.config to plain attributes as the first one requires every page to have frontmatter in format below, which is unnecessary and counterintuitive (beacuse of missing documentation ofc).

---
config:
  - author: @petr
---

Closes #548

@QingWei-Li QingWei-Li merged commit cd09d91 into docsifyjs:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants