Skip to content

Fixed: mermaid duplicated id, see #504 #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Fixed: mermaid duplicated id, see #504 #685

merged 3 commits into from
Nov 6, 2018

Conversation

upupming
Copy link
Contributor

@upupming upupming commented Nov 5, 2018

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@QingWei-Li
Copy link
Member

QingWei-Li commented Nov 6, 2018

It might be better to use a counter?

for example

var mid = 0

// ...
mermaid.render(mid++, code)
// ...

docs/markdown.md Outdated
@@ -36,6 +36,7 @@ window.$docsify = {
// <link rel="stylesheet" href="//cdn.jsdelivr.net/npm/mermaid/dist/mermaid.min.css">
// <script src="//cdn.jsdelivr.net/npm/mermaid/dist/mermaid.min.js"></script>

let num = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use es5 syntax.

@QingWei-Li QingWei-Li merged commit a72e749 into docsifyjs:master Nov 6, 2018
@upupming upupming deleted the patch-1 branch November 9, 2018 08:53
QingWei-Li pushed a commit that referenced this pull request Feb 19, 2019
Please makes sure these boxes are checked before submitting your PR, thank you!

* [x] Make sure you are merging your commits to `master` branch.
* [x] Add some descriptions and refer relative issues for you PR.
* [x] DO NOT include files inside `lib` directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants