Added filtering in sidebar for ignoreSubHeading #775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
ignoreSubHeading
whenloadSidebar
is false.The issue
When
{docsify-ignore}
is applied on a heading, the generated sidebar still contains the header and its subheaders. WhenloadSidebar
is false only thesidebar()
method is called so the filtering needs to be inserted there.docsify/src/core/render/index.js
Lines 93 to 107 in 8cd786c
I used classic splice() method and for loops to remove the header and all it's subheaders because I saw this method being used
subSidebar()
. I was probably better to just use the[].filter()
way but it works anyways.Please makes sure these boxes are checked before submitting your PR, thank you!
master
branch.lib
directory.