Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master branch ] fix: package security alerts #950

Merged
merged 3 commits into from
Nov 21, 2019

Conversation

anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Nov 21, 2019

Summary
There where approx of 90 high-security alerts and the npm audit fix PR merge recently was for the develop branch which I think is not currently published. Made one to fix them

Will merge this soon if not getting a review as this is quite an urgent step

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:
NA

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
NA

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
    Closes few of the audit issues

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

@anikethsaha anikethsaha requested a review from felangel November 21, 2019 19:55
@anikethsaha anikethsaha changed the title fix: package security alerts [master branch ] fix: package security alerts Nov 21, 2019
@anikethsaha anikethsaha merged commit 5a6289d into docsifyjs:master Nov 21, 2019
@anikethsaha
Copy link
Member Author

anikethsaha commented Nov 22, 2019

@timaschew Should I revert this ? in favor of this #934

I added this as I thought develop is for v5.

cc @felangel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants