Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user certificates #6

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

TheOneValen
Copy link
Contributor

Should fix #5

@eikek
Copy link
Member

eikek commented Apr 1, 2021

Thank you so much! Have some questions, hope you don't mind…

  1. tools:ignore="AcceptsUserCertificates" what does this mean?
  2. Did you maybe try it out with a custom build? (I'd then simply create a release and otherwise I'd try it on my phone first, just ftr)

@TheOneValen
Copy link
Contributor Author

Sure, no worries :)

  1. It's to suppress a warning in my current Android Studio Version. It is a security issue to allow user certificates. A user can install a certificate which can be used to decrypt the traffic of said user. Installing a user certificate on android since (don't know which version) also leads to a nagging message in the drawer. So you should know what certificates you install when you want to do that. Apps can be configured (in fact are so by default as we have seen with Feature request: Allow user/custom certificate CA #5) to ignore user certificates.
  2. I tried it on my emulator as I would otherwise have to remove the official app from my phone due to different signing.

@eikek eikek merged commit b30c067 into docspell:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow user/custom certificate CA
2 participants