Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

can override scan consistency #14

Merged
merged 8 commits into from
Mar 2, 2023
Merged

can override scan consistency #14

merged 8 commits into from
Mar 2, 2023

Conversation

CedricCouton
Copy link

No description provided.

pimpin
pimpin reviewed Mar 1, 2023
View reviewed changes
Copy link
Member

@pimpin pimpin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have some UT here, and maybe a bit of documentation.
I also would like to have implem review from a strong rubyiste.

@CedricCouton CedricCouton merged commit 08ddfe0 into master Mar 2, 2023
@CedricCouton CedricCouton deleted the can-override-scan-consitency branch March 2, 2023 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yanbonnel yanbonnel yanbonnel approved these changes

@pimpin pimpin pimpin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CedricCouton @pimpin @yanbonnel