This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
[BIC-1903] Add configuration for is null / is not valued #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimpin
approved these changes
Jan 24, 2024
lib/couchbase-orm/utilities/properties_always_exists_in_document.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Maybe we could also specify whats happen when properties_always_exist_in_document is set and a property is missing.
There was a problem hiding this comment.
Yes, by a comment you mean in the code + readme?
If I understand well it will crash, right?
pimpin
approved these changes
Jan 25, 2024
pimpin
reviewed
Mar 5, 2024
| key = "meta().id" if key.to_s == "id" | ||
| case | ||
| when value.nil? | ||
| when value.nil? && use_is_null | ||
| "#{key} IS NULL" |
There was a problem hiding this comment.
NB : This is should be "#{key} IS NOT NULL" (fixed in #35 )
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a property
properties_always_exists_in_documenton model to be able to useIS NULLinstead ofIS NOT VALUEDwhentrue