[SoftDeleteable] Fix filter not invalidating Query cache #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work, Alan. Thank you very much. 👏 |
AkenRoberts
added a commit
that referenced
this pull request
Apr 28, 2020
|
Tagged |
AkenRoberts
pushed a commit
that referenced
this pull request
Apr 28, 2020
* Add a failing test * Invalide the query cache when toggling the filter for an entity # Conflicts: # tests/Gedmo/SoftDeleteable/SoftDeleteableEntityTest.php
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the query cache is enabled for the ORM entity manager, enabling or disabling the soft deleteable filter for an entity doesn't change the hash of the filter. Therefore, the result cannot change.
The only way to invalidate the query cache is to set a varying (depending of the entity enabled or disabled) boolean parameter (the hash of a filter is calculated by serializing the parameters: https://github.com/doctrine/orm/blob/8c259ea5cb632dbb57001b2262048ae7fa52b102/lib/Doctrine/ORM/Query/Filter/SQLFilter.php#L110-L113).
The first commit is a failing test to show the issue, the second one fixes it.