[SoftDeleteable] Add support for non-\DateTime fields #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-93
force-pushed
the
soft-deleteable-fix-non-datetime-support
branch
3 times, most recently
from
7a24387
to
106b390
Compare
tobias-93
force-pushed
the
soft-deleteable-fix-non-datetime-support
branch
from
106b390
to
4b13db4
Compare
bobvandevijver
approved these changes
Apr 23, 2020
AkenRoberts
reviewed
May 10, 2020
|
Thank you @tobias-93. Just the one request to update the changelog. Also I don't see a CI build, so when you push that change hopefully the test suite will run. |
|
Thanks for the comment @AkenRoberts. I have changed it, however the 'support' was already there: https://github.com/Atlantic18/DoctrineExtensions/blob/e55a6727052f91834a968937c93b6fb193be8fb6/lib/Gedmo/SoftDeleteable/Mapping/Validator.php#L23 but it was not working. |
|
Thank you again. 🎉 |
|
Great, i'm looking for this, tnx! |
|
@aelfannir Make sure to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Timestampable has nice support for many types of date-fields, it was lacking in SoftDeleteable. In this PR, I reuse the logic already available in the Timestampable extension to provide the timestamp in the SoftDeleteable for the database field.