-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tree] Add pre-order and level-order traversals #2498
base: main
Are you sure you want to change the base?
Changes from all commits
a8ced41
490fff3
3f5ad50
90431f3
7f0889b
e1f3b78
5e0bded
f599f4a
1087769
079cec2
93f0f2c
fac750d
d46164c
db2c5ea
0037f83
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -39,6 +39,9 @@ | |||||
*/ | ||||||
class NestedTreeRepository extends AbstractTreeRepository | ||||||
{ | ||||||
public const TRAVERSAL_PRE_ORDER = 'pre_order'; | ||||||
public const TRAVERSAL_LEVEL_ORDER = 'level_order'; | ||||||
|
||||||
/** | ||||||
* Allows the following 'virtual' methods: | ||||||
* - persistAsFirstChild($node) | ||||||
|
@@ -1158,6 +1161,96 @@ | |||||
return $this->getNodesHierarchyQuery($node, $direct, $options, $includeNode)->getArrayResult(); | ||||||
} | ||||||
|
||||||
/** | ||||||
* @param object $root Root node of the parsed tree | ||||||
* @param object|null $node Current node. If null, first node will be returned | ||||||
* @param int|null $limit Maximum nodes to return. If null, all nodes will be returned | ||||||
* @param string $traversalStrategy Strategy to use to traverse tree | ||||||
* | ||||||
* @phpstan-assert self::TRAVERSAL_* $traversalStrategy | ||||||
* | ||||||
* @throws InvalidArgumentException if input is invalid | ||||||
*/ | ||||||
public function getNextNodesQueryBuilder($root, $node = null, ?int $limit = null, string $traversalStrategy = self::TRAVERSAL_PRE_ORDER): QueryBuilder | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Should we make this method |
||||||
{ | ||||||
$meta = $this->getClassMetadata(); | ||||||
$config = $this->listener->getConfiguration($this->_em, $meta->getName()); | ||||||
|
||||||
if (self::TRAVERSAL_PRE_ORDER === $traversalStrategy) { | ||||||
$qb = $this->childrenQueryBuilder($root, false, $config['left'], 'ASC', true); | ||||||
if (null !== $node) { | ||||||
$wrapped = new EntityWrapper($node, $this->_em); | ||||||
$qb | ||||||
->andWhere($qb->expr()->gt('node.'.$config['left'], ':lft')) | ||||||
->setParameter('lft', $wrapped->getPropertyValue($config['left'])) | ||||||
; | ||||||
} | ||||||
} elseif (self::TRAVERSAL_LEVEL_ORDER === $traversalStrategy) { | ||||||
if (!isset($config['level'])) { | ||||||
throw new \InvalidArgumentException('TreeLevel must be set to use level order traversal.'); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why |
||||||
} | ||||||
$qb = $this->childrenQueryBuilder($root, false, [$config['level'], $config['left']], ['DESC', 'ASC'], true); | ||||||
if (null !== $node) { | ||||||
$wrapped = new EntityWrapper($node, $this->_em); | ||||||
$qb | ||||||
->andWhere( | ||||||
$qb->expr()->orX( | ||||||
$qb->expr()->andX( | ||||||
$qb->expr()->gt('node.'.$config['left'], ':lft'), | ||||||
$qb->expr()->eq('node.'.$config['level'], ':lvl') | ||||||
), | ||||||
$qb->expr()->lt('node.'.$config['level'], ':lvl') | ||||||
) | ||||||
) | ||||||
->setParameter('lvl', $wrapped->getPropertyValue($config['level'])) | ||||||
->setParameter('lft', $wrapped->getPropertyValue($config['left'])) | ||||||
; | ||||||
} | ||||||
} else { | ||||||
throw new InvalidArgumentException(\sprintf('Invalid traversal strategy "%s".', $traversalStrategy)); | ||||||
} | ||||||
|
||||||
if (null !== $limit) { | ||||||
$qb->setMaxResults($limit); | ||||||
} | ||||||
|
||||||
return $qb; | ||||||
} | ||||||
|
||||||
/** | ||||||
* @param object $root Root node of the parsed tree | ||||||
* @param object|null $node Current node. If null, first node will be returned | ||||||
* @param int|null $limit Maximum nodes to return. If null, all nodes will be returned | ||||||
* @param self::TRAVERSAL_* $traversalStrategy Strategy to use to traverse tree | ||||||
*/ | ||||||
public function getNextNodesQuery($root, $node = null, ?int $limit = null, string $traversalStrategy = self::TRAVERSAL_PRE_ORDER): Query | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
{ | ||||||
return $this->getNextNodesQueryBuilder($root, $node, $limit, $traversalStrategy)->getQuery(); | ||||||
} | ||||||
|
||||||
/** | ||||||
* @param object $root Root node of the parsed tree | ||||||
* @param object|null $node Current node. If null, first node will be returned | ||||||
* @param self::TRAVERSAL_* $traversalStrategy Strategy to use to traverse tree | ||||||
*/ | ||||||
public function getNextNode($root, $node = null, string $traversalStrategy = self::TRAVERSAL_PRE_ORDER): ?object | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
{ | ||||||
return $this->getNextNodesQuery($root, $node, 1, $traversalStrategy)->getOneOrNullResult(); | ||||||
} | ||||||
|
||||||
/** | ||||||
* @param object $root Root node of the parsed tree | ||||||
* @param object|null $node Current node. If null, first node will be returned | ||||||
* @param int|null $limit Maximum nodes to return. If null, all nodes will be returned | ||||||
* @param self::TRAVERSAL_* $traversalStrategy Strategy to use to traverse tree | ||||||
* | ||||||
* @return array<object> | ||||||
*/ | ||||||
public function getNextNodes($root, $node = null, ?int $limit = null, string $traversalStrategy = self::TRAVERSAL_PRE_ORDER): array | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
{ | ||||||
return $this->getNextNodesQuery($root, $node, $limit, $traversalStrategy)->getArrayResult(); | ||||||
} | ||||||
|
||||||
protected function validate() | ||||||
{ | ||||||
return Strategy::NESTED === $this->listener->getStrategy($this->_em, $this->getClassMetadata()->name)->getName(); | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,136 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the Doctrine Behavioral Extensions package. | ||
* (c) Gediminas Morkevicius <gediminas.morkevicius@gmail.com> http://www.gediminasm.org | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Gedmo\Tests\Tree; | ||
|
||
use Doctrine\Common\EventManager; | ||
use Doctrine\ORM\OptimisticLockException; | ||
use Gedmo\Tests\Tool\BaseTestCaseORM; | ||
use Gedmo\Tests\Tree\Fixture\RootCategory; | ||
use Gedmo\Tree\TreeListener; | ||
|
||
/** | ||
* These are tests for Tree traversal | ||
*/ | ||
final class NestedTreeTraversalTest extends BaseTestCaseORM | ||
{ | ||
private const CATEGORY = RootCategory::class; | ||
|
||
protected function setUp(): void | ||
{ | ||
parent::setUp(); | ||
|
||
$evm = new EventManager(); | ||
$evm->addEventSubscriber(new TreeListener()); | ||
|
||
$this->getDefaultMockSqliteEntityManager($evm); | ||
$this->populate(); | ||
} | ||
|
||
/** | ||
* @dataProvider provideNextNodes | ||
*/ | ||
public function testNextNode(array $expected, string $strategy): void | ||
{ | ||
$repo = $this->em->getRepository(self::CATEGORY); | ||
$lvl1 = $repo->findOneBy(['title' => 'Part. 1']); | ||
|
||
$result = []; | ||
|
||
$current = null; | ||
while (null !== ($current = $repo->getNextNode($lvl1, $current, $strategy))) { | ||
$result[] = $current->getTitle(); | ||
} | ||
static::assertSame($expected, $result); | ||
} | ||
|
||
/** | ||
* @dataProvider provideNextNodes | ||
*/ | ||
public function testNextNodes(array $expected, string $strategy): void | ||
{ | ||
$repo = $this->em->getRepository(self::CATEGORY); | ||
$lvl1 = $repo->findOneBy(['title' => 'Part. 1']); | ||
|
||
$nextNodes = $repo->getNextNodes($lvl1, null, 10, $strategy); | ||
|
||
static::assertSame($expected, array_column($nextNodes, 'title')); | ||
} | ||
|
||
public function provideNextNodes(): iterable | ||
{ | ||
yield 'Pre-order traversal' => [ | ||
['Part. 1', 'Part. 1.1', 'Part. 1.2', 'Part. 1.2.1', 'Part. 1.2.2', 'Part. 1.3'], | ||
'pre_order', | ||
]; | ||
yield 'Level-order traversal' => [ | ||
['Part. 1.2.1', 'Part. 1.2.2', 'Part. 1.1', 'Part. 1.2', 'Part. 1.3', 'Part. 1'], | ||
'level_order', | ||
]; | ||
} | ||
|
||
protected function getUsedEntityFixtures(): array | ||
{ | ||
return [self::CATEGORY]; | ||
} | ||
|
||
/** | ||
* @throws OptimisticLockException | ||
*/ | ||
private function populate(): void | ||
{ | ||
$lvl1 = new RootCategory(); | ||
$lvl1->setTitle('Part. 1'); | ||
|
||
$lvl2 = new RootCategory(); | ||
$lvl2->setTitle('Part. 2'); | ||
|
||
$lvl11 = new RootCategory(); | ||
$lvl11->setTitle('Part. 1.1'); | ||
$lvl11->setParent($lvl1); | ||
|
||
$lvl12 = new RootCategory(); | ||
$lvl12->setTitle('Part. 1.2'); | ||
$lvl12->setParent($lvl1); | ||
|
||
$lvl121 = new RootCategory(); | ||
$lvl121->setTitle('Part. 1.2.1'); | ||
$lvl121->setParent($lvl12); | ||
|
||
$lvl122 = new RootCategory(); | ||
$lvl122->setTitle('Part. 1.2.2'); | ||
$lvl122->setParent($lvl12); | ||
|
||
$lvl13 = new RootCategory(); | ||
$lvl13->setTitle('Part. 1.3'); | ||
$lvl13->setParent($lvl1); | ||
|
||
$lvl21 = new RootCategory(); | ||
$lvl21->setTitle('Part. 2.1'); | ||
$lvl21->setParent($lvl2); | ||
|
||
$lvl22 = new RootCategory(); | ||
$lvl22->setTitle('Part. 2.2'); | ||
$lvl22->setParent($lvl2); | ||
|
||
$this->em->persist($lvl1); | ||
$this->em->persist($lvl2); | ||
$this->em->persist($lvl11); | ||
$this->em->persist($lvl12); | ||
$this->em->persist($lvl121); | ||
$this->em->persist($lvl122); | ||
$this->em->persist($lvl13); | ||
$this->em->persist($lvl21); | ||
$this->em->persist($lvl22); | ||
$this->em->flush(); | ||
$this->em->clear(); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved to the
## [Unreleased]
section