Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if xml value is set, change value in class metadata #2670

Merged
merged 7 commits into from
Aug 31, 2023
Merged

fix: if xml value is set, change value in class metadata #2670

merged 7 commits into from
Aug 31, 2023

Conversation

gfuentesboost
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.32% 🎉

Comparison is base (4fd6a62) 79.22% compared to head (1eeaa23) 79.55%.
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
+ Coverage   79.22%   79.55%   +0.32%     
==========================================
  Files         161      161              
  Lines        8415     8412       -3     
==========================================
+ Hits         6667     6692      +25     
+ Misses       1748     1720      -28
Files Changed Coverage Δ
src/References/Mapping/Driver/Xml.php 79.41% <100.00%> (+79.41%) ⬆️

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gfuentesboost
Copy link
Contributor Author

what else is required for the PR?

franmomu
franmomu approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

tests/Gedmo/Mapping/Xml/ReferencesMappingTest.php Outdated Show resolved Hide resolved
@phansys phansys added Bug A confirmed bug in Extensions that needs fixing. References labels Aug 31, 2023
@phansys phansys merged commit c4c6f85 into doctrine-extensions:main Aug 31, 2023
21 checks passed
@phansys
Copy link
Collaborator

phansys commented Aug 31, 2023

Thank you @gfuentesboost!

phansys pushed a commit to phansys/DoctrineExtensions that referenced this pull request Sep 3, 2023
@gfuentesboost @phansys
fix: if xml value is set, change value in class metadata (doctrine-ex…
05e2457 
…tensions#2670)
phansys pushed a commit to phansys/DoctrineExtensions that referenced this pull request Sep 3, 2023
@gfuentesboost @phansys
fix: if xml value is set, change value in class metadata (doctrine-ex…
cff9ec9 
…tensions#2670)
phansys pushed a commit to phansys/DoctrineExtensions that referenced this pull request Sep 3, 2023
@gfuentesboost @phansys
fix: if xml value is set, change value in class metadata (doctrine-ex…
94244d4 
…tensions#2670)
phansys pushed a commit to phansys/DoctrineExtensions that referenced this pull request Sep 3, 2023
@gfuentesboost @phansys
fix: if xml value is set, change value in class metadata (doctrine-ex…
95f7c90 
…tensions#2670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@franmomu franmomu franmomu approved these changes

Assignees
No one assigned
Labels
Bug A confirmed bug in Extensions that needs fixing. References
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfuentesboost @phansys @franmomu