Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Continuous Integration workflow template #17

Merged
merged 2 commits into from
Jan 9, 2021
Merged

Create a Continuous Integration workflow template #17

merged 2 commits into from
Jan 9, 2021

Conversation

nicwortel
Copy link
Contributor

@nicwortel nicwortel commented Dec 5, 2020

Creates a workflow template for a Continuous Integration workflow, which:

  • Runs PHPUnit on PHP versions 7.2 - 8.0
  • Installs Xdebug for code coverage (as PCOV support was introduced in PHPUnit 8 and many projects still use PHPUnit 7)
  • Installs PCOV for code coverage
  • Caches Composer dependencies to speed up the build
  • Includes a job running on PHP 7.2 which tests the minimum dependency version requirements.
  • Uploads coverage information to Codecov

Based on doctrine/data-fixtures#353, which was in turn based on doctrine/event-manager#34, doctrine/lexer#48, and similar changes in other Doctrine repositories.

Pending #16 which discusses the introduction of the ramsey/composer-install action to install/update and cache Composer dependencies.

@nicwortel nicwortel marked this pull request as ready for review December 8, 2020 07:57
@greg0ire
Copy link
Member

Installs Xdebug for code coverage (as PCOV support was introduced in PHPUnit 8 and many projects still use PHPUnit 7)

IMO we should not encourage them to, and instead favor PCOV (I remember migrating many projects to it actually, so when we drop PHP 7.1 we should be able to stop using XDebug entirely).

Use PCOV instead of Xdebug for code coverage

Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
@nicwortel nicwortel requested a review from greg0ire December 11, 2020 08:09
@greg0ire greg0ire merged commit 2c60b2f into doctrine:main Jan 9, 2021
@nicwortel nicwortel deleted the ci-workflow-template branch January 9, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants