Drop milestone creation step

[greg0ire]

The case when you do not need a milestone (because it is the end of the
branch) is not handled: closing what you intend to be the last milestone of a branch will create another milestone, which you have to close manually which would not create another milestone itself because the closed milestone would be empty.

Pointed out by @morozov in doctrine/dbal#4251 (comment)
Asked about at https://discourse.laminas.dev/t/laminas-automatic-releases-how-do-you-stop-the-milestones/1824
Also discussed in resolved discussion at doctrine/dbal#4251 (comment)

[morozov]

This is how I'd prefer to work with milestones in DBAL. Not sure if this should be dictated to other projects.

Since it's a template, would it make sense to leave it as is and let the project maintainer decide which bits to use?

[greg0ire]

Since it's a template, would it make sense to leave it as is and let the project maintainer decide which bits to use?

Would somebody in Doctrine be likely to keep that step in a repo? If nobody does, let's just remove it.

[Ocramius]

I don't see any damage done in milestones being created automatically: easier to assign issues to them, without having to look at what was released last.

This is more about having the milestones ready for others to start using them after "firing zeh missiles" and logging off.

[greg0ire]

@Ocramius the "damage" at discussion would be the creation of a 2.4.9 milestone when we mean milestone 2.4.8 to be the last of branch 2.4.x . One could argue that the benefit of not having to create them manually outweights the drawback of having to delete that last milestone (or having it around for no reason).

[Ocramius]

Can always be deleted - all it takes is 2 clicks 🤷‍♀️

…

On Wed, Sep 16, 2020, 16:42 Grégoire Paris ***@***.***> wrote: @Ocramius <https://github.com/Ocramius> the "damage" at discussion would be the creation of a 2.4.9 milestone when we mean milestone 2.4.8 to be the last of branch 2.4.x . One could argue that the benefit of not having to create them manually outweights the drawback of having to delete that last milestone (or having it around for no reason). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFVEGV2YBTAAXL74JG5DDSGDFF7ANCNFSM4RMUYXYQ> .

[greg0ire]

Okay let's close then :)