Skip to content

Commit

Permalink
Fix remaining test failures
Browse files Browse the repository at this point in the history
  • Loading branch information
ostrolucky committed Jan 6, 2022
1 parent b9088db commit 5c086cb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions Tests/DependencyInjection/ConfigurationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
use PHPUnit\Framework\TestCase;

use function class_exists;
use function extension_loaded;

use const PHP_VERSION_ID;

class ConfigurationTest extends TestCase
{
Expand All @@ -23,8 +26,13 @@ class ConfigurationTest extends TestCase
/** @runInSeparateProcess */
public function testGetConfigTreeBuilderDoNotUseDoctrineCommon(): void
{
if (extension_loaded('pcov') && PHP_VERSION_ID >= 80100) {
$this->markTestSkipped('Segfaults, see https://github.com/krakjoe/pcov/issues/84');

This comment has been minimized.

Copy link
@dmaicher

dmaicher Jan 6, 2022

Contributor

nice 👍 finally that test fail is gone

}

$configuration = new Configuration(true);
$configuration->getConfigTreeBuilder();

$this->assertFalse(class_exists('Doctrine\Common\Proxy\AbstractProxyFactory', false));
}
}
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"symfony/cache": "^4.3.3|^5.0|^6.0",
"symfony/config": "^4.4.3|^5.0|^6.0",
"symfony/console": "^3.4.30|^4.3.3|^5.0|^6.0",
"symfony/dependency-injection": "^4.3.3|^5.0|^6.0",
"symfony/dependency-injection": "^4.4.18|^5.0|^6.0",
"symfony/deprecation-contracts": "^2.1|^3",
"symfony/doctrine-bridge": "^4.4.22|^5.2.7|^6.0",
"symfony/framework-bundle": "^3.4.30|^4.3.3|^5.0|^6.0",
Expand Down

0 comments on commit 5c086cb

Please sign in to comment.