Fix master-slaves deprecation from dbal 2.11

[Dodenis]

Since dbal 2.11 MasterSlaveConnection is deprecated and the doctrine:database:create and doctrine:database:drop commands no longer work with the "slaves" option. doctrine/dbal#4054

Issue : #1214

[ostrolucky]

You should rather report a BC break in DBAL repo.

[stof]

I'm quite sure this PR makes a BC break in the bundle config by removing support for slaves keys as soon as the new version of DBAL is installed.

What we need is a proper migration to the new names, where the bundle config also uses them and deprecates master/slave. Then, the bundle would use the right name on the DBAL side based on the DBAL version (whatever the user-facing name is).

My proposal is to fix only the commands in that PR (to fix compat with 2.11), and perform the master/slave to primary/replicas in the config in a separate PR.

@ostrolucky no. The 2 commands are using Connection::getParams which is tagged as @internal so that cannot be considered as a regression in DBAL.

[Dodenis]

@stof I'm agree with you.

I modify this PR to fix only the commands

[kralos]

You should rather report a BC break in DBAL repo.

See doctrine/dbal#4295

[ostrolucky]

Let's merge after doctrine/dbal#4308 is merged. If we merge this first, there will no longer be a pressure to fix a BC break in DBAL. This is not a pressing issue, people can just hold off from upgrading dbal.